Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renamed env variable to prevent collisions #400

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jsalaber
Copy link
Contributor

@jsalaber jsalaber commented Jun 6, 2024

Summary by Sourcery

This pull request addresses a potential environment variable collision by renaming 'LOCAL' to 'DVC_API_LOCAL' in the API configuration.

  • Bug Fixes:
    • Renamed environment variable from 'LOCAL' to 'DVC_API_LOCAL' to prevent collisions.

@jsalaber jsalaber requested a review from a team June 6, 2024 15:28
Copy link

sourcery-ai bot commented Jun 6, 2024

Reviewer's Guide by Sourcery

This pull request renames an environment variable to prevent potential collisions. Specifically, the variable process.env.LOCAL has been changed to process.env.DVC_API_LOCAL in the src/api/common.ts file.

File-Level Changes

Files Changes
src/api/common.ts Renamed environment variable to prevent collisions.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jsalaber - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@jsalaber jsalaber merged commit 27c96c8 into main Jun 6, 2024
1 check passed
@jsalaber jsalaber deleted the change-local-env-name branch June 6, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants