Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: return proper variable value prompt for cleanup variable value #382

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

jsalaber
Copy link
Contributor

@jsalaber jsalaber commented Apr 30, 2024

Changes

When cleaning up a variable, it will prompt you to input a variable value to replace with. Fixed it to use the proper type of the variable value instead of always String

Screenshot 2024-04-30 at 4 12 44 PM

@jsalaber jsalaber requested review from ajwootto, emmawillis and a team April 30, 2024 20:11
@jsalaber
Copy link
Contributor Author

jsalaber commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsalaber and the rest of your teammates on Graphite Graphite

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jsalaber - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

src/ui/prompts/variablePrompts.ts Show resolved Hide resolved
@jsalaber jsalaber merged commit acccb96 into main Apr 30, 2024
9 checks passed
@jsalaber jsalaber deleted the fix-type-cleanup-variable branch April 30, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants