-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register page #2
base: master
Are you sure you want to change the base?
Conversation
@Balanced02 This is some great stuff! Really! |
@dave-ok I'll modify sir, email would be used but not required as some of those that'll be needing help might not have. Username still stays, I'll change username to first name and add last name too... so, we'll be using, firstName, lastName, email, phoneNumber, password. where email is optional |
@Balanced02 Maybe I am wrong but someone with an android phone for instance must have an email address. And since we are building a mobile app. Unless I am missing something |
@dave-ok not 100% of them... quite a number of them just have the mail address but don't know how to use it, some self don't have an address at all... |
@Balanced02 Haha. That's true. I am guessing phone numbers may need to be unique. Cos that seems like the only unique identifier at this point. Do we have a way to verify the number, so people don't pick numbers arbitrarily, eventually preventing the actual owners from being able to register or even impersonating them? |
@dave-ok we have to verify otp... then the login step would be different... Similar to the server I added you to. Phone number, send otp and verify |
@Balanced02 I checked it. Pretty interesting stuff. I am trying to understand a few things. Without verification can the user log in or only a verified account can log in? The reason for the using the session middleware I am guessing is because the user does not have a token yet? I have never used it before |
I've effected all changes and corrections. Please review, and approve as appropriate. Thanks |
Added Register page
UI fixes on login page
Fixed error message display on Text Inputs