Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register page #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Register page #2

wants to merge 4 commits into from

Conversation

Balanced02
Copy link
Contributor

Added Register page
UI fixes on login page
Fixed error message display on Text Inputs

@Balanced02 Balanced02 added the feature Extra attention is needed label Apr 22, 2020
@Balanced02
Copy link
Contributor Author

Simulator Screen Shot - iPhone 11 - 2020-04-22 at 23 45 04
Simulator Screen Shot - iPhone 11 - 2020-04-22 at 23 45 12
Simulator Screen Shot - iPhone 11 - 2020-04-22 at 23 45 22
Simulator Screen Shot - iPhone 11 - 2020-04-22 at 23 46 04

@Balanced02 Balanced02 self-assigned this Apr 24, 2020
@dave-ok
Copy link
Member

dave-ok commented Apr 24, 2020

@Balanced02 This is some great stuff! Really!
A couple of things though. I thought we agreed to use emails for registration or is that what the username stands for? If it is then, maybe we should indicate this or is there a separate username cos there isn't a provision for this in the user model?
I like the fact that registration is so much simpler. But, if this is all that is needed at the point of registration then we may have to modify the register endpoint to require only these info. Then user can update their profile details in a separate endpoint.

@Balanced02
Copy link
Contributor Author

@dave-ok I'll modify sir, email would be used but not required as some of those that'll be needing help might not have. Username still stays, I'll change username to first name and add last name too...

so, we'll be using, firstName, lastName, email, phoneNumber, password. where email is optional

@dave-ok
Copy link
Member

dave-ok commented Apr 24, 2020

@Balanced02 Maybe I am wrong but someone with an android phone for instance must have an email address. And since we are building a mobile app. Unless I am missing something

@Balanced02
Copy link
Contributor Author

@dave-ok not 100% of them... quite a number of them just have the mail address but don't know how to use it, some self don't have an address at all...

@dave-ok
Copy link
Member

dave-ok commented Apr 24, 2020

@Balanced02 Haha. That's true. I am guessing phone numbers may need to be unique. Cos that seems like the only unique identifier at this point. Do we have a way to verify the number, so people don't pick numbers arbitrarily, eventually preventing the actual owners from being able to register or even impersonating them?

@Balanced02
Copy link
Contributor Author

@dave-ok we have to verify otp... then the login step would be different...

Similar to the server I added you to. Phone number, send otp and verify

@dave-ok
Copy link
Member

dave-ok commented Apr 24, 2020

@Balanced02 I checked it. Pretty interesting stuff. I am trying to understand a few things. Without verification can the user log in or only a verified account can log in? The reason for the using the session middleware I am guessing is because the user does not have a token yet? I have never used it before

@Balanced02
Copy link
Contributor Author

I've effected all changes and corrections. Please review, and approve as appropriate. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants