Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create build users action description #775

Closed
wants to merge 1 commit into from
Closed

fix create build users action description #775

wants to merge 1 commit into from

Conversation

mjgallag
Copy link
Contributor

@mjgallag mjgallag commented Dec 8, 2023

Description

UID range start is off by 1 in action description:
* Create build users (UID 300-332) and group (GID 30000)
* Create build users (UID 301-332) and group (GID 30000)

Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@Hoverbear
Copy link
Contributor

😅 It seems some changes at our org-level have disabled force merging and we had a job that won't complete for folks who aren't maintainers.

Extremely unfortunate. We need to make some tweaks.

In the meantime, I'll re-create this PR and reference this one. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants