-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist files added to /etc past system updates for SteamOS 3.6+ #1355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Got a couple comments for you, but otherwise LGTM!
Also, do you know of a way to "mimic" one of these breaking-updates? Does SteamOS have a command that I can run that will do this (even if there is no update available)? |
I was told I could try to switch to the beta channel to simulate an update, but I really didn't want to do that on my Deck 😅. Especially not after manually reinstalling Nixpkgs the last time. |
Co-authored-by: Cole Helbling <[email protected]>
steamos, not streamos lol
Thanks, that helped me reproduce the issue! I had to move your addition outside of the block it was in (since that branch is only taken on old SteamOS versions that didn't have the Nix offload path) but after that it survived an update to the beta channel (and prior to adding this file, did not). EDIT: note to myself (or anybody who stumbles here in the future): If you come across the error |
For this kind of tests it's handy to have a SteamOS VM, you can install Nix there, switch between branches and OS versions and reproduce the problem (the Here's how to create one: |
Description
As of SteamOS 3.6, only files under
/etc
specifically allowed are persisted during system updates.The Determinate Systems installer has a Planner target for the Steam Deck, and performs the Nixpkgs setup as a multi-user installation. However, it does not currently create the allowlist needed for the install to survive system updates and breaks as a result.
This PR adds in this allowlist for the Determinate Systems installer as helpfully defined in this comment on NixOS/nix#7173.
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: