Allow Fedora / CentOS / RHEL to handle JPEG #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow Fedora / RHEL / CentOS to avoid JPEG issues On Fedora / RHEL / CentOS, JPEG functions aren't included in libfreeimage, so loading failure should be ignored on these platforms. This can be checked by looking for the /etc/redhat-release file. Clean up double checking on JPEG Remove empty lines
|
I'm fine with adding this, but I think it really should be opt-in. This is something that will have to be documented either way, but at least if it's opt-in they'll get an exception telling them about a missing function rather than, if they're using any of these functions, an access violation they'll waste time trying to debug before they finally ask for help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Fedora / RHEL / CentOS to avoid JPEG issues
On Fedora / RHEL / CentOS, JPEG functions aren't included in
libfreeimage, so loading failure should be ignored on these platforms.
This can be checked by looking for the /etc/redhat-release file.