Port: Prevent duplicate policy violations #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ports DependencyTrack/dependency-track#4234 The implementation differs in the following ways: * Locks are not acquired in-memory but instead through the database (shedlock), since it must work across multiple app instances. * Risk of duplicates during reconciliation of violations was already fixed when implementing the CEL-based policy engine. * A UNIQUE constraint is added to prevent duplicate records from being created at the database-level. Now-redundant indexes are removed. Signed-off-by: nscuro <[email protected]>
nscuro
added
defect
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ports DependencyTrack/dependency-track#4234.
Addressed Issue
Relates to DependencyTrack/hyades#1358
Additional Details
The implementation differs in the following ways:
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have updated the migration changelog accordinglyThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly