Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FK constraints to enable cascading deletes #1046

Merged
merged 6 commits into from
Jan 31, 2025

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jan 31, 2025

Description

Recreate FK constraints to include the ON DELETE CASCADE clause.
Refactor the relevant application code of manual deletion logic.

Addressed Issue

Closes DependencyTrack/hyades#1641

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added the enhancement New feature or request label Jan 31, 2025
@sahibamittal sahibamittal added this to the 5.6.0 milestone Jan 31, 2025
Copy link

codacy-production bot commented Jan 31, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.06% (target: -1.00%) 80.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (425cabc) 22402 18585 82.96%
Head commit (bc1abff) 22316 (-86) 18500 (-85) 82.90% (-0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1046) 15 12 80.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal marked this pull request as ready for review January 31, 2025 14:30
@sahibamittal sahibamittal requested a review from nscuro January 31, 2025 16:00
@sahibamittal sahibamittal requested a review from nscuro January 31, 2025 16:47
@sahibamittal sahibamittal merged commit eae1325 into main Jan 31, 2025
9 checks passed
@sahibamittal sahibamittal deleted the issue-enable-cascading-delete-on-fk-constraints branch January 31, 2025 17:17
pkwiatkowski1 pushed a commit to pkwiatkowski1/hyades-apiserver that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update FK constraints to enable cascading deletes
2 participants