Port : Fix REST endpoints for adding tags

[sahibamittal]

Description

Fixes REST endpoints for adding tags.

Addressed Issue

Ports DependencyTrack/dependency-track#4543
Port change DependencyTrack/hyades#1358

Checklist

• I have read and understand the contributing guidelines
• This PR fixes a defect, and I have provided tests to verify that the fix is effective
• This PR implements an enhancement, and I have provided tests to verify that it works as intended
• This PR introduces changes to the database model, and I have updated the migration changelog accordingly
• This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

[nscuro]

@sahibamittal The test is failing because this condition:

hyades-apiserver/src/main/java/org/dependencytrack/resources/v1/ProjectResource.java

Lines 647 to 652 in 6f4ed40

	if (isUniqueConstraintViolation(e)) {
	throw new ClientErrorException(Response
	.status(Response.Status.CONFLICT)
	.entity("A project with the specified name and version already exists.")
	.build());
	}

can no longer happen in this location.

The unique constraint violation originating from the database will only be thrown when the DB transaction commits.

Because the statement in question is also wrapped in a callInTransaction:

hyades-apiserver/src/main/java/org/dependencytrack/resources/v1/ProjectResource.java

Line 607 in 6f4ed40

final Project updatedProject = qm.callInTransaction(() -> {

the transaction will only commit after that call completes, so technically here.

The solution is to wrap the outermost callInTransaction in a try-catch block, catching RuntimeException, and doing the isUniqueConstraintViolation check there.

I am not sure why that behavior changed in this particular PR though...

[sahibamittal]

@sahibamittal The test is failing because this condition:

hyades-apiserver/src/main/java/org/dependencytrack/resources/v1/ProjectResource.java

Lines 647 to 652 in 6f4ed40

	if (isUniqueConstraintViolation(e)) {
	throw new ClientErrorException(Response
	.status(Response.Status.CONFLICT)
	.entity("A project with the specified name and version already exists.")
	.build());
	}

can no longer happen in this location.

The unique constraint violation originating from the database will only be thrown when the DB transaction commits.

Because the statement in question is also wrapped in a callInTransaction:

hyades-apiserver/src/main/java/org/dependencytrack/resources/v1/ProjectResource.java

Line 607 in 6f4ed40

final Project updatedProject = qm.callInTransaction(() -> {

the transaction will only commit after that call completes, so technically here.

The solution is to wrap the outermost callInTransaction in a try-catch block, catching RuntimeException, and doing the isUniqueConstraintViolation check there.

I am not sure why that behavior changed in this particular PR though...

Thanks for checking Niklas 👍🏼
I've moved RuntimeException outside but apart from isUniqueConstraintViolation it should throw exception as is else ClientErrorException being thrown inside will get caught here.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ +0.00% (target: -1.00%)	✅ 89.36% (target: 70.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (6f4ed40)	22318	18502	82.90%
Head commit (e95dc31)	22330 (+12)	18513 (+11)	82.91% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1042)	47	42	89.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}