Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port : Fix broken pagination in /api/v1/cwe endpoint #1041

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jan 28, 2025

Description

Fixes broken pagination in /api/v1/cwe endpoint.

Addressed Issue

Ports DependencyTrack/dependency-track#4459
Port change DependencyTrack/hyades#1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jan 28, 2025
@sahibamittal sahibamittal added this to the 5.6.0 milestone Jan 28, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 6bdcfe71 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6bdcfe7) Report Missing Report Missing Report Missing
Head commit (d8a7a81) 22394 18576 82.95%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1041) 10 10 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@sahibamittal sahibamittal merged commit 3d3bcef into main Jan 28, 2025
8 checks passed
@sahibamittal sahibamittal deleted the port-Fix-broken-pagination-in-/api/v1/cwe branch January 28, 2025 11:36
pkwiatkowski1 pushed a commit to pkwiatkowski1/hyades-apiserver that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants