Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port : Remove docker-compose.yml #1040

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Jan 28, 2025

Description

Removed docker-compose.yml version top-level element (obsolote)

Addressed Issue

Ports DependencyTrack/dependency-track#4301
Port change DependencyTrack/hyades#1358

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added docker Pull requests that update Docker code v4-port PRs that were ported from the Dependency-Track v4.x code base labels Jan 28, 2025
@sahibamittal sahibamittal added this to the 5.6.0 milestone Jan 28, 2025
@nscuro
Copy link
Member

nscuro commented Jan 28, 2025

@sahibamittal Actually, I think this file can be removed entirely. It doesn't contain any of the other Hyades services, so it's a bit pointless to keep around 😅

@sahibamittal sahibamittal changed the title Port : Removed docker-compose.yml version top-level element (obsolote) Port : Remove docker-compose.yml Jan 28, 2025
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed code: best code 🙌

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3d3bcef) 22394 18576 82.95%
Head commit (9f413aa) 22394 (+0) 18576 (+0) 82.95% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1040) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro merged commit 3025e61 into main Jan 28, 2025
9 checks passed
@nscuro nscuro deleted the port-remove-version-docker-compose branch January 28, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants