Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serviceAccount -> serviceAccountName #203

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

sdibernardo
Copy link
Contributor

According to the Kubernetes documentation the service account should be referenced via serviceAccountName

@sdibernardo sdibernardo requested a review from a team as a code owner February 7, 2025 15:18
@nscuro
Copy link
Member

nscuro commented Feb 7, 2025

@sdibernardo Do we know when k8s deprecated serviceAccount in favour of serviceAccountName? As in, since which k8s version is serviceAccountName available?

@sdibernardo
Copy link
Contributor Author

sdibernardo commented Feb 11, 2025

According to this issue, the deprecation should be around early 2017.

@nscuro
Copy link
Member

nscuro commented Feb 11, 2025

Thanks, should be fine then. Could you please sign-off your commit so the DCO check passes? You can find instructions for that by clicking on the Details link next to the failing DCO check.

@nscuro nscuro added the enhancement New feature or request label Feb 12, 2025
@nscuro nscuro changed the title Update ServiceAccout to ServiceAccountName serviceAccount -> serviceAccountName Feb 12, 2025
@nscuro nscuro merged commit 08c30de into DependencyTrack:main Feb 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants