Uv #8194
Draft
Uv #8194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version of ruff installed by uv wants to change a file too...
This is pretty hacky, and basically involved fighting round permissions issues inside the lambda handler. I couldn't find much prior art apart from https://github.com/aws-samples/amazon-bedrock-serverless-prompt-chaining/blob/e583e865e8f140f93ff582e1ab17670feebdbf28/stacks/util.py#L18 Not sure if this is the best way to go, or if we'd be better off calling uv export in CI, and documenting the fact you need to call 'uv export' if you want to run 'cdk synth' locally. we could even have scripts/cdk-synth.sh which created and removed the necessary requirements.txt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI isn't quite there yet.
Also I got sucked into making BundleOptions work on the trigger cdk. I'm not sure this is the best approach. It feels quite brittle and like it will be hard to debug when it breaks. Just calling
uv exportbeforecdk synthorcdk deployis probably a better bet. However I've left the commit in so that it's there if wanted.Assuming the synth step of CI is fixed then next step would be to push to the development branch and see if the deploy steps work. Then doing some playing to check if the CI importers run. Then maybe the requirements dir can be deleted.
I haven't thought past that.