-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable simple region checking for cli #664
Conversation
Things we want to still add:
|
@hboisgon I added your |
Discussed briefly with Dirk that it's better to update the data catalog so the CRS like 54009 validates more easily. Should not have any impact on users. |
I figured out what the issue was with the grid model precip example Hélène found. The validator was actually only validating the first step in the file provided, not all of them. This is now rectified and it should all work. Very good catch @hboisgon ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes! Thanks @savente93
Issue addressed
Fixes #638
Explanation
Given that we only support bbox and geom regions in the export CLI, I thought it was appropriate to do the same here. We can add to this over time but then we will need a more concrete proposal for who it should look and what we should support so I think this is okay for now. Then at least people can use the most simple variants.
Checklist
main
Additional Notes (optional)
Add any additional notes or information that may be helpful.