-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export improvements #660
Export improvements #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there @savente93, thanks for looking into it!
I think the multiple -t options is actually implemented (it was support multiple sources which at the time were using -t instead of -s now :) )
What I miss is passing the extra arguments from config and for you to check if the config is properly parsed by your function still with the changes implemented
Co-authored-by: hboisgon <[email protected]>
Sorry I don't understand what you are asking here, could you rephrase it for me? other than that, all of the comments should be resolved now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good :) I tried to explain better what I meant but your solution works too.
Issue addressed
Fixes #657
Explanation
Checklist
main
Additional Notes (optional)