Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix raster.set_crs #659

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Bugfix raster.set_crs #659

merged 2 commits into from
Nov 21, 2023

Conversation

hboisgon
Copy link
Contributor

@hboisgon hboisgon commented Nov 21, 2023 •
edited
Loading

Issue addressed

Fixes #613

Explanation

Function was modified but did not account that input_crs could be directly of type CRS anymore
Also modified changelog to take into account release 0.9.1

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed
  • Updated changelog.rst if needed

@hboisgon hboisgon self-assigned this Nov 21, 2023
savente93
savente93 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hboisgon hboisgon merged commit 1f32f4a into main Nov 21, 2023
@hboisgon hboisgon deleted the geodataset_crs branch November 21, 2023 09:03
@savente93 savente93 mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savente93 savente93 savente93 approved these changes

Assignees

@hboisgon hboisgon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

could not reproject for geodataset
2 participants
@hboisgon @savente93