always upload chaches on main #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
NA
Explanation
We have a few flaky tests that can sometimes fail due to time out. This can prevent the cache being generated needed for the test CI to be run. I'd rather not, but assuming that tests on main should always pass is one of the loosest assumptions I think we can make in this context. Therefore, with this PR, the cache CI should always save the cache, regardless of the test outcome. If we ever manage to address the flaky tests, this should be removed again.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.