Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make skeletons take holy damage #2854

Merged
merged 9 commits into from
Feb 3, 2025

Conversation

AeraAuling
Copy link
Contributor

@AeraAuling AeraAuling commented Feb 2, 2025

About the PR

simple enough change, makes skeletons take holy damage like the undead they are

Why / Balance

it's more of a flavor thing than anything, skeletons are rarely used as is but there's been talk of some skeletal shenanigans, so this is a thing. perhaps one day, holy damage will actually be relevant.

Technical details

Media

3f02e0adb72389fde901c5ebfcedd695

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • tweak: Skeletons now take Holy damage as they are undead.

@AeraAuling AeraAuling requested a review from a team as a code owner February 2, 2025 12:12
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files size/XS Under 16 lines labels Feb 2, 2025
@deltanedas deltanedas enabled auto-merge (squash) February 2, 2025 12:48
@dvir001
Copy link
Contributor

dvir001 commented Feb 2, 2025

Is there a way to heal it or we have to swap the skeleton parts to normal human parts? :trollface:

@Radezolid Radezolid disabled auto-merge February 2, 2025 15:24
Radezolid
Radezolid previously approved these changes Feb 2, 2025
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on direction's input.

Lyndomen
Lyndomen previously approved these changes Feb 3, 2025
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Direction approved

Resources/Prototypes/Entities/Mobs/Species/skeleton.yml Outdated Show resolved Hide resolved
Signed-off-by: AeraAuling <[email protected]>
@AeraAuling AeraAuling dismissed stale reviews from Lyndomen and Radezolid via 176256c February 3, 2025 05:20
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change Delta-v to DeltaV

Signed-off-by: AeraAuling <[email protected]>
Signed-off-by: AeraAuling <[email protected]>
@deltanedas deltanedas merged commit f483146 into DeltaV-Station:master Feb 3, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review size/XS Under 16 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants