Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOS app for the PDA #2812

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

rosieposieeee
Copy link
Contributor

@rosieposieeee rosieposieeee commented Jan 27, 2025

About the PR

Port of impstation/imp-station-14#1450

Adds a cartridge to the PDA which allows anyone to send an SOS on security radio. For balance, does not include location in any way - I can add this if we want it, though. Has a 90s cooldown by default, and supports adding other types of SOS with different messages. Impstation added this because they want to remove common radio; I think even with common, this would just be a good way to get attention, as sec often has trouble paying attention given how much spam and crap is there.

I added a popup as visual feedback, since there is no other feedback that your SOS went through / is on cooldown. I could add a noise, I know how! Not sure what noise to use though.

I also added a cartridge sprite which the original PR was missing entirely, and put it in the HOP's locker.

Making a roundstart cartridge uninstallable will unfortunately require a separate PR.

sos_pda.mp4

image

image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Changelog
🆑

  • add: Test Merge: Added an SOS program to all crew PDAs. Upon pressing it, it sends a message on sec radio requesting help along with the name on your ID, followed by a cooldown.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi size/L 256-1023 lines labels Jan 27, 2025
Copy link
Contributor

github-actions bot commented Jan 27, 2025

RSI Diff Bot; head commit edcb245 merging into bc66b63
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_DV/Objects/Devices/cartridge.rsi

State Old New Status
cart-sos Added

Resources/Textures/_Impstation/Objects/Devices/sos.rsi

State Old New Status
icon Added

Edit: diff updated after edcb245

@github-actions github-actions bot added size/M 64-255 lines and removed size/L 256-1023 lines labels Jan 27, 2025
@rosieposieeee rosieposieeee marked this pull request as ready for review January 28, 2025 00:39
@rosieposieeee rosieposieeee requested review from a team as code owners January 28, 2025 00:39
@ThataKat
Copy link
Contributor

Direction here,

Out of all of the suggested possible features I think the ability to remove it from the PDA is most pressing. Besides that, we can pull a test merge when it's ready and see how people feel about stuff like locational info or medical comms.

@rosieposieeee
Copy link
Contributor Author

??????????????? never even seen this test fail before

@Emily9031
Copy link
Contributor

Maybe instead of it being a roundstart thing, it should be just a cartridge in the HoS's locker, and they can give it out to people who should have it. That should stop it from being abusable.

@rosieposieeee
Copy link
Contributor Author

Maybe instead of it being a roundstart thing, it should be just a cartridge in the HoS's locker, and they can give it out to people who should have it. That should stop it from being abusable.

it doesnt make a ton of sense for NT to have an SOS app that the pda doesn't even come with, i mean real life phones all come with emergency dialing. also handing out the program would be a pain every shift, its not very interesting. if anything, i could just remove it from passenger PDAs and then give the hop a cart. fuck them tides

@rosieposieeee

This comment was marked as outdated.

@ThataKat
Copy link
Contributor

Direction here,

Probably worth a descriptive (ish) changelog on this one so people actually know what's up with it. I'd also appreciate if the CL makes it clear it's a test merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants