-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports slime person sounds from Impstation #2693
base: master
Are you sure you want to change the base?
Conversation
I think my only criticisms are that the gasping and whistling emote cut out very abruptly. I'm not sure if theres anything we can do about that but real |
It would mostly involve messing with the ogg files, which I thiiiink are just edited default sounds, so if anyone is a wizard at audacity, you could make it work. |
yeah, these are the default human sounds run through a set of filters. i implemented these originally and i can contact the person who made the edits to see if she wants to do another pass on gasp and whistle. i will say that imo its not noticeable in the context of a round |
I don't wanna peanut post but I think Epstein Engine ones sound better and not as loud but like I dunno |
Can deffo take a look at it, at the very least. I'll clone the repo, compare sounds, see which ones are better in the end. |
I think both impstation and EE have some good ones so I guess if both could be combined that would be nice, given some of impstation slime emotes sound rather silly. Like one of impstation screams literally sounds like a train screeching to a halt which I think is the first one showcased in the video |
|
I got the Einstein Engine sounds, so I'll double check all of that before merging. |
So Einstein doesn't have the variety that Imp does, Also I don't think that they have gasping emotes. So I think I'll probably just use Imp stuff with the caveat that hivehum can maybe nab some differently filtered ones. |
got in contact with harpy, she will have to remake the filter preset she used for these but she is interested in replacing the gasp and whistle sounds. will report back when i have the new files |
That is hella cool. If you also don't mind, could you ask her how she'd like to be attributed for editing the sounds? I currently just put in that the sounds were edited by you, which is inaccurate. So would she rather it be rewritten on her or just attributed to Impstation in general? |
credit the sounds as from "harpy and fiend" please :) |
Oh tomce can you add this PR to this impstation/imp-station-14#842 |
Wait wrong PR I thought this was markings pr |
these sound so awful and sharp |
Einstein Engine*, sorry, just noticed this |
Don't want to peanut post but what's the status on this? |
I've been mildly busy this week, but generally I need to get in contact with @hivehum to see how the remade sounds are going, then change them out and fix attributions. That's pretty much it |
About the PR
Ported various slime sounds from this, that and also this, all from our friends from Impstation! Slimes now sound very reverby and mildly spooky. Also added funny emotes to the slime mobs!
Why / Balance
Default human sound bad.
Technical details
More sounds
stolenported from Impstation with attributionMessed with upstream files to change the default sounds the Slime People make.
Added a new emoteSound for slimes so they can do some slime emotes.
Media
2025-01-11.00-21-25.mp4
Requirements
Breaking changes
Pretty sure that the snoring trait specifically grabs the default soundCollection of snoring, so that no work until refactor.
Changelog
🆑