Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports slime person sounds from Impstation #2693

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Tomce795
Copy link
Contributor

@Tomce795 Tomce795 commented Jan 10, 2025

About the PR

Ported various slime sounds from this, that and also this, all from our friends from Impstation! Slimes now sound very reverby and mildly spooky. Also added funny emotes to the slime mobs!

Why / Balance

Default human sound bad.

Technical details

More sounds stolen ported from Impstation with attribution
Messed with upstream files to change the default sounds the Slime People make.
Added a new emoteSound for slimes so they can do some slime emotes.

Media

2025-01-11.00-21-25.mp4

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Pretty sure that the snoring trait specifically grabs the default soundCollection of snoring, so that no work until refactor.

Changelog
🆑

  • add: Ported various slime sounds from Impstation. Now Slime People sound very different and can also pop and bubble! Also let mob slimes use pop, bubble and squish emotes.

@Tomce795 Tomce795 requested review from a team as code owners January 10, 2025 22:24
@github-actions github-actions bot added S: Needs Review size/M 64-255 lines Changes: YML Changes any yml files Changes: Localization Changes any ftl files Changes: Audio Changes any audio files and removed S: Needs Review size/M 64-255 lines labels Jan 10, 2025
@Lyndomen
Copy link
Contributor

I think my only criticisms are that the gasping and whistling emote cut out very abruptly. I'm not sure if theres anything we can do about that but real

@Tomce795
Copy link
Contributor Author

It would mostly involve messing with the ogg files, which I thiiiink are just edited default sounds, so if anyone is a wizard at audacity, you could make it work.

@hivehum
Copy link

hivehum commented Jan 10, 2025

yeah, these are the default human sounds run through a set of filters. i implemented these originally and i can contact the person who made the edits to see if she wants to do another pass on gasp and whistle. i will say that imo its not noticeable in the context of a round

@fow111
Copy link

fow111 commented Jan 11, 2025

I don't wanna peanut post but I think Epstein Engine ones sound better and not as loud but like I dunno

@Tomce795
Copy link
Contributor Author

I don't wanna peanut post but I think Epstein Engine ones sound better and not as loud but like I dunno

Can deffo take a look at it, at the very least. I'll clone the repo, compare sounds, see which ones are better in the end.

@fow111
Copy link

fow111 commented Jan 11, 2025

I think both impstation and EE have some good ones so I guess if both could be combined that would be nice, given some of impstation slime emotes sound rather silly. Like one of impstation screams literally sounds like a train screeching to a halt which I think is the first one showcased in the video

@github-actions github-actions bot added the size/M 64-255 lines label Jan 11, 2025
@deltanedas
Copy link
Member

Epstein Engine

@Tomce795
Copy link
Contributor Author

I got the Einstein Engine sounds, so I'll double check all of that before merging.

@Tomce795 Tomce795 marked this pull request as draft January 11, 2025 11:11
@Tomce795
Copy link
Contributor Author

So Einstein doesn't have the variety that Imp does, Also I don't think that they have gasping emotes. So I think I'll probably just use Imp stuff with the caveat that hivehum can maybe nab some differently filtered ones.

@Tomce795 Tomce795 marked this pull request as ready for review January 11, 2025 12:46
@hivehum
Copy link

hivehum commented Jan 12, 2025

got in contact with harpy, she will have to remake the filter preset she used for these but she is interested in replacing the gasp and whistle sounds. will report back when i have the new files

@Tomce795
Copy link
Contributor Author

That is hella cool. If you also don't mind, could you ask her how she'd like to be attributed for editing the sounds? I currently just put in that the sounds were edited by you, which is inaccurate. So would she rather it be rewritten on her or just attributed to Impstation in general?

@hivehum
Copy link

hivehum commented Jan 12, 2025

credit the sounds as from "harpy and fiend" please :)

@Lyndomen
Copy link
Contributor

Oh tomce can you add this PR to this impstation/imp-station-14#842

@Lyndomen
Copy link
Contributor

Wait wrong PR I thought this was markings pr

@Piras314
Copy link
Contributor

these sound so awful and sharp

@fow111
Copy link

fow111 commented Jan 15, 2025

Epstein Engine

Einstein Engine*, sorry, just noticed this

@fow111
Copy link

fow111 commented Jan 16, 2025

Don't want to peanut post but what's the status on this?

@Tomce795
Copy link
Contributor Author

Don't want to peanut post but what's the status on this?

I've been mildly busy this week, but generally I need to get in contact with @hivehum to see how the remade sounds are going, then change them out and fix attributions. That's pretty much it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Audio Changes any audio files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants