Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cool Ass Survival Knives #2342

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Unkn0wnGh0st333
Copy link
Contributor

About the PR

Adds two new knives that are direct upgrades to the survival knife. The idea is sort of based around the shivs, with the knives being plasma and uranium variants.

Why / Balance

To give salvage a way to mine for an upgrade, the entire concept hasn't been fully fleshed out though.
Buuut better knives is always cool

Technical details

  • Sprites by JustAnOrange
  • Simple coding to add the items in game
  • Way for salvage to obtain them (Crafting?)

Media

image from JustAnOrange
image

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Yo momma

Changelog
🆑 Unkn0wnGh0st333, JustAnOrange

  • add: New salvage knife variants have arrived to Nanotrasen stations.!

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi size/M 64-255 lines labels Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

RSI Diff Bot; head commit 0d7cf08 merging into 7f608b6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Melee/plasma_survival_knife.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added
storage Added

Resources/Textures/DeltaV/Objects/Weapons/Melee/uranium_survival_knife.rsi

State Old New Status
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added
storage Added

@JustAnOrng
Copy link

I'd make the crafting recipe;

Survival Knife, 5 reinforced plasma/uranium glass, space glue.
But that's just me. Also, correct the punctuation in the changelog.

@JustAnOrng
Copy link

Also make it salv loot

@JustAnOrng
Copy link

luv u josuah
<3

@JustAnOrng
Copy link

I'd make the crafting recipe;

Survival Knife, 5 reinforced plasma/uranium glass, space glue. But that's just me. Also, correct the punctuation in the changelog.

could also make it require rods/steel/plasteel, just so you need more stuff to make it.

@Bonktrauma
Copy link
Contributor

How much longer till this is complete enough to leave draft

@Bonktrauma
Copy link
Contributor

I wish to see cool knifes ingame

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 19, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NoElkaTheGod
Copy link
Contributor

Plasma cutter real

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants