Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sentry crash-reporting opt-out #211

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Add Sentry crash-reporting opt-out #211

merged 3 commits into from
Dec 20, 2024

Conversation

IanVS
Copy link
Contributor

@IanVS IanVS commented Dec 20, 2024 •
edited
Loading

Closes #200

Before After

@IanVS IanVS requested review from nbrownus, jasikpark and johnmaguire and removed request for jasikpark December 20, 2024 17:27
@nbrownus
Copy link
Contributor

nbrownus commented Dec 20, 2024 •
edited
Loading

Do we need to tear anything down when disabling?

nm I see it

@IanVS
Copy link
Contributor Author

IanVS commented Dec 20, 2024

It won't re-enable if it's toggled on, that will only take effect when the app restarts. But it disables immediately when toggled off.

@IanVS IanVS merged commit 3d250f4 into main Dec 20, 2024
4 checks passed
@IanVS IanVS deleted the sentry-opt-out branch December 20, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbrownus nbrownus nbrownus approved these changes

@johnmaguire johnmaguire johnmaguire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate Sentry crash reporting opt-out
3 participants
@IanVS @nbrownus @johnmaguire