Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move svg generation to rust #777

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Move svg generation to rust #777

merged 11 commits into from
Jan 31, 2025

Conversation

edenhaus
Copy link
Contributor

No description provided.

@edenhaus edenhaus added the pr: refactor PR with code refactoring label Jan 22, 2025
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #777 will improve performances by 69.4%

Comparing rust-svg (5ee176d) with dev (77e91d1)

Summary

⚡ 1 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_get_svg_map 275.4 ms 162.6 ms +69.4%

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.02%. Comparing base (1333345) to head (5ee176d).
Report is 1 commits behind head on dev.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #777      +/-   ##
==========================================
- Coverage   93.07%   93.02%   -0.06%     
==========================================
  Files         199      199              
  Lines        6716     6608     -108     
  Branches      309      292      -17     
==========================================
- Hits         6251     6147     -104     
+ Misses        398      396       -2     
+ Partials       67       65       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edenhaus edenhaus marked this pull request as ready for review January 31, 2025 18:20
@edenhaus edenhaus merged commit d547d78 into dev Jan 31, 2025
24 checks passed
@edenhaus edenhaus deleted the rust-svg branch January 31, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: refactor PR with code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant