Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whale-api-client): new default url #2178

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

eli-lim
Copy link
Contributor

@eli-lim eli-lim commented Feb 2, 2024

What this PR does / why we need it:

  • Updates the default URLs to point to <network>.ocean.jellyfishsdk.com
  • Adds the necessary test

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 31ad329
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/65c07d9f7437ae00096f8e62
😎 Deploy Preview https://deploy-preview-2178--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e04c2b0) 91.84% compared to head (9eee43f) 93.86%.

❗ Current head 9eee43f differs from pull request most recent head 31ad329. Consider uploading reports for the commit 31ad329 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2178      +/-   ##
==========================================
+ Coverage   91.84%   93.86%   +2.02%     
==========================================
  Files         374      374              
  Lines       11301    11306       +5     
  Branches     1477     1479       +2     
==========================================
+ Hits        10379    10612     +233     
+ Misses        891      670     -221     
+ Partials       31       24       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eli-lim
Copy link
Contributor Author

eli-lim commented Feb 2, 2024

not sure why release apps is failing

@canonbrother
Copy link
Contributor

canonbrother commented Feb 2, 2024

not sure why release apps is failing

testing [cbc2bd5] (cbc2bd5)
Dropped

the error is only from legacy-api and status-api at release-apps.yml

> [linux/arm64 15/18] RUN npm ci:
283.0 npm ERR! code ECONNRESET
283.0 npm ERR! errno ECONNRESET
283.0 npm ERR! network request to https://registry.npmjs.org/typescript failed, reason: socket hang up
283.0 npm ERR! network This is a problem related to network connectivity.
283.0 npm ERR! network In most cases you are behind a proxy or have bad network settings.
283.0 npm ERR! network 
283.0 npm ERR! network If you are behind a proxy, please make sure that the
283.0 npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

tested docker build locally seems fine...

Copy link

github-actions bot commented Feb 2, 2024

Docker build preview for jellyfish/apps is ready!

Built with commit f4c997a

  • ghcr.io/birthdayresearch/legacy-api:pr-2178
  • ghcr.io/birthdayresearch/playground-api:pr-2178
  • ghcr.io/birthdayresearch/status-api:pr-2178
  • ghcr.io/birthdayresearch/whale-api:pr-2178

You can also get an immutable image with the commit hash

  • ghcr.io/birthdayresearch/legacy-api:f4c997ae2d32ca644bdc5aee5a0f3d885f79859f
  • ghcr.io/birthdayresearch/playground-api:f4c997ae2d32ca644bdc5aee5a0f3d885f79859f
  • ghcr.io/birthdayresearch/status-api:f4c997ae2d32ca644bdc5aee5a0f3d885f79859f
  • ghcr.io/birthdayresearch/whale-api:f4c997ae2d32ca644bdc5aee5a0f3d885f79859f

@canonbrother
Copy link
Contributor

@eli-lim hmmm.. the CI is working good now.. wondering have you fixed something??

@canonbrother canonbrother enabled auto-merge (squash) February 2, 2024 11:08
@canonbrother canonbrother force-pushed the eli/whale-api-client-url branch 2 times, most recently from a2bd9b3 to 4873a86 Compare February 5, 2024 06:15
@canonbrother canonbrother force-pushed the eli/whale-api-client-url branch from 4873a86 to 31ad329 Compare February 5, 2024 06:18
@canonbrother canonbrother merged commit 26b8eb1 into main Feb 5, 2024
26 of 31 checks passed
@canonbrother canonbrother deleted the eli/whale-api-client-url branch February 5, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants