Skip to content

Commit

Permalink
chore(packages/jellyfish-wallet-encrypted): use simple `hardTime > ea…
Browse files Browse the repository at this point in the history
…syTime` condition to reduce test flakiness (#1998)

#### What this PR does / why we need it:

I would forgo this test completely (if this is still causing flakiness)
since we can't control (or should not) the CI environment. Tests
concurrency within the pipeline (Jest concurrent and Docker spinup) skew
"hardTime" and "easyTime" making the test number very unreliable.

We could isolate the tests but frankly too much trouble to prove an
otherwise proven theory.

#### Which issue(s) does this PR fixes?:

Fixes part of #1771
  • Loading branch information
fuxingloh authored Jan 31, 2023
1 parent 1497d2c commit eefd5dd
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ it('configurable params (easy-hard)', async () => {

// significantly slower
// technically it is 8x harder, but they can be processed in parallel
expect(hardTime).toBeGreaterThan(easyTime * 2)
expect(hardTime).toBeGreaterThan(easyTime)
})

0 comments on commit eefd5dd

Please sign in to comment.