-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/maps #23
Draft
David-Lor
wants to merge
19
commits into
develop
Choose a base branch
from
feature/maps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Feature/maps #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MongoDB is not yet required, as we currently only have unit tests
This allows acquiring location data from stops, unavailable from HTML data source
This comment has been minimized.
This comment has been minimized.
David-Lor
force-pushed
the
feature/maps
branch
2 times, most recently
from
September 26, 2021 09:22
ebfa2f9
to
5931a99
Compare
…le to package; Validate at least one stop with location when getting multi-stop map
David-Lor
force-pushed
the
feature/maps
branch
from
September 26, 2021 09:25
5931a99
to
0c9ac9f
Compare
Write cache of queried Google Maps & Streetview pictures with metadata. Pending implementation of reading before requesting Google Maps API, and returning cached pictures; plus integration with Telegram File IDs.
Add aliases to routes, using plurals as standard ways (e.g. "/stops/{stop_id}" instead of "/stop/{stop_id}"), but supporting old form
This comment has been minimized.
This comment has been minimized.
Rename stops-tags relation header on multi-stop map endpoint
Avoid conflict with /stops/map endpoint being handled as a /stop/{stop_id} endpoint. Endpoints may end up being refactored in the future
Closed
Instead of defining the TTL on the Mongo cached-stops index, define the TTL to 1 second of expiration, while a new datetime field on documents indicate when the document shall expire.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.