Fixed bug for old versions of Windows #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneider92
reviewed
Sep 24, 2024
source/threads/thread.cpp
Outdated
| @@ -47,11 +47,17 @@ size_t thread::hardware_concurrency() noexcept { | |||
| #ifdef CRCPP_WIN_OS | |||
|
|
|||
| # include <Windows.h> | |||
| # include <VersionHelpers.h> | |||
|
|
|||
| void thread::set_name(std::string_view name) noexcept { | |||
| const std::wstring utf16_name(name.begin(), | |||
There was a problem hiding this comment.
What about making the wstring construction conditional too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug related to the fact that before Windows 10 version 1607, the windows api does not have the
::SetThreadDescriptionfunction for setting the name for a thread.When the application tries to call a system function, it crashes.