Fix min PHPStan requirement #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version `1.12.19` does not currently exist. I think this might be a typo from `1.12.9`, but becuase I am not sure of this, I just require the current latests `1.12.*` version
|
Thanks for this. It's the second mistake I've made with the versions. I'm going to use this PR as a base and add in some more tests to make sure that I don't add other mistakes. |
|
@dragosprotung FYI I've added this test script to help prevent similar problems: c863ab7 |
DaveLiddament
approved these changes
Jan 15, 2025
|
Thank you @DaveLiddament |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
1.12.19does not currently exist. I think this might be a typo from1.12.9, but becuase I am not sure of this, I just require the current latests1.12.*version