Skip to content

Commit

Permalink
Revert to output channel minimization by default
Browse files Browse the repository at this point in the history
  • Loading branch information
DaveBenham committed Dec 28, 2024
1 parent 7ad1a54 commit b2d80d5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1693,9 +1693,9 @@ If the actual input is monophonic, then the input is replicated to match the eff
If the actual input is polyphonic with fewer channels than the effective input channel count, then missing channels are assigned constant 0V.

#### Polyphonic Outputs
The number of output channels matches the effective input channel count by default. In this case the effective input channels map directly to the output channels. Unused channels are constant 0V.
By default the number of output channels is minimized to match the selected number of crossfaded channels. In this case the start channel is always assigned to output channel 1, and there are no unused channels in the output.

A module context menu option is available to minimize the number of output channels to match the selected number of crossfaded channels. In this case the start channel is always assigned to output channel 1, and there are no unused channels in the output.
A module context menu option is available to disable the output channel minimization. In this case the effective input channels map directly to the output channels. Unused input channels become constant 0V in the output.

### Standard Venom Context Menus
[Venom Themes](#themes), [Custom Names](#custom-names), and [Parameter Locks and Custom Defaults](#parameter-locks-and-custom-defaults) are available via standard Venom context menus.
Expand Down
4 changes: 1 addition & 3 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
- VCO Unit
- Shape mode now always has 6 options, regardless which waveform is selected. The square waveform replicates the three options to make 6.
- Poly Fade
- Poly outputs now preserve all input channels by default
- Added context menu option to minimize output channels like old behavior
- Old patches automatically minimize output channels
- Added context menu option to disable output channel minimization
- Multi Merge
- Add context menu options to explicitly set the number of channels on inputs, overriding the actual input channel count.

Expand Down
4 changes: 1 addition & 3 deletions src/PolyFade.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ struct PolyFade : VenomModule {
};

bool resetIfOff = true;
bool minimizeChannels = false, oldMinimizeChannels = false;
bool minimizeChannels = true, oldMinimizeChannels = true;
float phasor = 0.f;
float slewRate[4]{0.f, 333.f, 167.f, 100.f};
float curSlew = -1.f;
Expand Down Expand Up @@ -343,8 +343,6 @@ struct PolyFade : VenomModule {
resetIfOff = json_boolean_value(val);
if((val = json_object_get(rootJ, "minimizeChannels")))
minimizeChannels = json_boolean_value(val);
else
minimizeChannels = true;
}

};
Expand Down

0 comments on commit b2d80d5

Please sign in to comment.