Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_integration_aws_account] Fix panic when resources_config is omitted #2749

Conversation

ktmq
Copy link
Contributor

@ktmq ktmq commented Jan 3, 2025

Raised here: #2747

resources_config is a required block, but we weren't

  • validating that exactly one block was defined
  • handling the case where the block is nil

This fix adds validation to ensure the block is present to match the expectation defined in the docs.

@ktmq ktmq requested review from a team as code owners January 3, 2025 16:12
@amaskara-dd
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 3, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-03 17:40:50 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in master is 1m.


2025-01-03 17:42:08 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit cc1920f into master Jan 3, 2025
18 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the katie.mckew/awscustexp-171-fix-nil-resources-config-panic branch January 3, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants