Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] WAF Builder #363

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

[WIP] WAF Builder #363

wants to merge 32 commits into from

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Jan 7, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 79.56989% with 133 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (990e73c) to head (c088e11).

Files with missing lines Patch % Lines
src/configuration/configuration_manager.cpp 66.83% 43 Missing and 21 partials ⚠️
src/interface.cpp 40.00% 23 Missing and 10 partials ⚠️
src/configuration/legacy_rule_parser.cpp 64.28% 9 Missing and 6 partials ⚠️
src/builder/ruleset_builder.cpp 95.95% 1 Missing and 3 partials ⚠️
src/configuration/common/common.hpp 69.23% 2 Missing and 2 partials ⚠️
src/builder/action_mapper_builder.cpp 87.50% 1 Missing and 2 partials ⚠️
src/configuration/data_parser.cpp 94.23% 1 Missing and 2 partials ⚠️
src/builder/matcher_builder.cpp 75.00% 1 Missing and 1 partial ⚠️
src/builder/processor_builder.cpp 77.77% 0 Missing and 2 partials ⚠️
src/configuration/actions_parser.cpp 91.66% 0 Missing and 2 partials ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   84.95%   84.66%   -0.30%     
==========================================
  Files         157      161       +4     
  Lines        7994     8025      +31     
  Branches     3551     3568      +17     
==========================================
+ Hits         6791     6794       +3     
- Misses        459      480      +21     
- Partials      744      751       +7     
Flag Coverage Δ
waf_test 84.66% <79.56%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 7, 2025

Benchmarks

Benchmark execution time: 2025-01-09 12:04:26

Comparing candidate commit c088e11 in PR branch anilm3/waf_builder with baseline commit 990e73c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants