Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Object view #341

Draft
wants to merge 41 commits into
base: anilm3/v2
Choose a base branch
from
Draft

[WIP] Object view #341

wants to merge 41 commits into from

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Oct 1, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 91.05691% with 33 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (4f40664) to head (1165e50).

Files with missing lines Patch % Lines
src/object_view.hpp 86.27% 3 Missing and 11 partials ⚠️
src/iterator.cpp 92.00% 0 Missing and 10 partials ⚠️
src/iterator.hpp 68.75% 2 Missing and 3 partials ⚠️
src/condition/ssrf_detector.cpp 33.33% 0 Missing and 2 partials ⚠️
src/condition/match_iterator.hpp 66.66% 0 Missing and 1 partial ⚠️
src/tokenizer/generic_sql.cpp 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           anilm3/v2     #341      +/-   ##
=============================================
+ Coverage      84.50%   84.66%   +0.16%     
=============================================
  Files            153      155       +2     
  Lines           7841     7997     +156     
  Branches        3502     3558      +56     
=============================================
+ Hits            6626     6771     +145     
+ Misses           466      463       -3     
- Partials         749      763      +14     
Flag Coverage Δ
waf_test 84.66% <91.05%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Oct 1, 2024

Benchmarks

Benchmark execution time: 2024-12-02 14:15:26

Comparing candidate commit 1165e50 in PR branch anilm3/object_view with baseline commit 4f40664 in branch anilm3/v2.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random

  • 🟩 execution_time [-11.808ms; -11.741ms] or [-4.007%; -3.984%]

@Anilm3 Anilm3 force-pushed the anilm3/object_view branch from 63d6557 to 98c50a8 Compare October 3, 2024 18:23
@Anilm3 Anilm3 changed the base branch from master to anilm3/v2 October 9, 2024 09:36
@Anilm3 Anilm3 force-pushed the anilm3/object_view branch from 5bb6c6e to fdadce8 Compare October 21, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants