-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for dynamic exclusion filter data #316
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
==========================================
- Coverage 83.70% 83.68% -0.03%
==========================================
Files 137 137
Lines 6065 6086 +21
Branches 2869 2882 +13
==========================================
+ Hits 5077 5093 +16
- Misses 367 369 +2
- Partials 621 624 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-07-11 15:26:12 Comparing candidate commit 60ef9b7 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 0 unstable metrics. scenario:lowercase_transformer.random
scenario:remove_nulls_transformer.random
scenario:ruleset_1.10.0.random
|
73e52c7
to
c526d8a
Compare
This PR introduces support for configurable exclusion filter data, allowing for exclusion filters with a specified matcher but undefined data from the get-go. This allows the update of the matcher without having to reinstantiate all exclusion filters and enables the suspicious attacker blocking features, which relies on a specific denylist.
The configuration key for this new dynamic data is
exclusion_data
, and the schema is exactly the same as the one used forrules_data
, for example:Related Jira: APPSEC-53545