-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rule override for adding tags #313
Conversation
BenchmarksBenchmark execution time: 2024-07-11 14:20:40 Comparing candidate commit b9c7f24 in PR branch Found 8 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 0 unstable metrics. scenario:bool_equals_matcher.random
scenario:exact_match_matcher.random
scenario:float_equals_matcher.random
scenario:lowercase_transformer.random
scenario:phrase_match_matcher.enforce_word_boundary.random
scenario:phrase_match_matcher.random
scenario:remove_nulls_transformer.random
scenario:signed_equals_matcher.random
scenario:unsigned_equals_matcher.random
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 83.61% 83.70% +0.09%
==========================================
Files 137 137
Lines 6054 6065 +11
Branches 2859 2869 +10
==========================================
+ Hits 5062 5077 +15
+ Misses 369 367 -2
+ Partials 623 621 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This PR introduces support for adding tags to a rule through rule overrides. The schema of
rules_override
has been updated to support a newtags
field, which is a map containing the new tags which must be added to a given set of rules. The set of tags to add must not overlap with the set of default tags already available on the rule; any overlapping tag will be ignored. For example:Tags will only be used for reporting purposes and won't impact other overrides or exclusion filters targeting a tag set.
Related Jira: APPSEC-11810