-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit the number of transformers per rule or input #309
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #309 +/- ##
==========================================
+ Coverage 83.59% 83.61% +0.01%
==========================================
Files 137 137
Lines 6041 6047 +6
Branches 2848 2854 +6
==========================================
+ Hits 5050 5056 +6
Misses 370 370
Partials 621 621
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2024-06-24 15:18:44 Comparing candidate commit bb6303a in PR branch Found 9 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 0 unstable metrics. scenario:bool_equals_matcher.random
scenario:float_equals_matcher.random
scenario:ip_match_matcher.random
scenario:is_xss_matcher.random
scenario:lowercase_transformer.random
scenario:regex_match_matcher.case_insensitive_flag.random
scenario:regex_match_matcher.case_insensitive_option.random
scenario:regex_match_matcher.lowercase_transformer.random
scenario:remove_nulls_transformer.random
scenario:signed_equals_matcher.random
scenario:string_equals_matcher.random
scenario:unsigned_equals_matcher.random
|
This PR introduces a limit to the number of transformers that can be used on a single input. This limit has been arbitrarily set to 10 transformers in order to account for future requirements and is currently not user configurable.
The limit applies to transformers in a rule:
As well as transformers applied to a single input:
Related Jira: APPSEC-53552