Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace over fmtlib to avoid symbol conflicts #237

Merged
merged 4 commits into from
Nov 21, 2023

Conversation

Anilm3
Copy link
Collaborator

@Anilm3 Anilm3 commented Nov 20, 2023

  • Add ddwaf namespace over fmtlib to avoid symbol conflicts
  • Remove unnecessary fmtlib code

@Anilm3 Anilm3 requested a review from a team as a code owner November 20, 2023 17:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (55879e9) 83.23% compared to head (42ca068) 83.23%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         106      106           
  Lines        4176     4176           
  Branches     1914     1914           
=======================================
  Hits         3476     3476           
  Misses        279      279           
  Partials      421      421           
Flag Coverage Δ
waf_test_none 83.13% <ø> (ø)
waf_test_sse2 83.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anilm3 Anilm3 merged commit f1dc07f into master Nov 21, 2023
25 checks passed
@Anilm3 Anilm3 deleted the anilm3/hide-fmtlib branch November 21, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants