Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go.mod file for v2 #45

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Conversation

eliottness
Copy link
Contributor

And remove retract directive since we changed major

Signed-off-by: Eliott Bouhana <[email protected]>
@Hellzy
Copy link
Contributor

Hellzy commented Nov 13, 2023

Maybe we should retract 2.0.0, it won't be useable

@eliottness eliottness force-pushed the eliott.bouhana/fix-import-path branch from 2caefa3 to 2a36db1 Compare November 14, 2023 10:28
@eliottness
Copy link
Contributor Author

  • Retract v2.0.0
  • Fix error case where we would send a nil wafObject to ddwaf_run instead of a nil value

@eliottness eliottness force-pushed the eliott.bouhana/fix-import-path branch from 2a36db1 to d156c2d Compare November 14, 2023 10:39
@eliottness
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 14, 2023

🚂 MergeQueue

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

you can cancel this operation by commenting your pull request with /merge -c!

@eliottness eliottness merged commit 03c4651 into main Nov 14, 2023
@eliottness eliottness deleted the eliott.bouhana/fix-import-path branch November 14, 2023 10:57
@dd-devflow
Copy link

dd-devflow bot commented Nov 14, 2023

🚂 MergeQueue

This PR is already merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants