feat: add windows support #40
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # context.go # decoder.go # include/ddwaf.h # lib/darwin-amd64/_libddwaf.dylib # lib/darwin-arm64/_libddwaf.dylib # lib/linux-amd64/libddwaf.so # lib/linux-arm64/libddwaf.so # waf.go # waf_dl.go # waf_dl_unsupported.go # waf_test.go
|
Sorry to break it to you but 386 in not working on purego side 😭 Here is the remnant https://github.com/ebitengine/purego/blob/main/func.go#L293. But we can still keep the CI because we want our CI to handle at least one platform not supported so we can test the unsupported code paths |
Merged
eliottness
reviewed
Nov 6, 2023
RomainMuller
force-pushed
the
rmuller/windows/APPSEC-10171
branch
from
f462bb8 to
77e1af5
Compare
RomainMuller
force-pushed
the
rmuller/windows/APPSEC-10171
branch
from
be97573 to
c05e57a
Compare
RomainMuller
force-pushed
the
rmuller/windows/APPSEC-10171
branch
from
c05e57a to
641f9f1
Compare
# Conflicts: # _tools/libddwaf-updater/update.go # internal/lib/doc.go # internal/lib/vendor_test.go # internal/lib/vendor_windows_386.go # internal/lib/vendor_windows_amd64.go # internal/lib/windows-386/ddwaf.dll # internal/lib/windows-386/vendor.go # internal/lib/windows-amd64/ddwaf.dll # internal/lib/windows-amd64/vendor.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.