Define CFLAG -D_GNU_SOURCE as per liburing ./configure #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ./configure script for liburing sets the CFLAG -D_GNU_SOURCE, so we should set it on our build.rs as well. Fixes the following build error with musl libc: `error: unknown type name 'cpu_set_t'` On musl, `cpu_set_t` is only defined when _GNU_SOURCE is set.
glommer
approved these changes
May 28, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
./configurescript for liburing setsCFLAG=-D_GNU_SOURCE, so we should set it on ourbuild.rsas well.Motivation
Fixes the following build error with musl libc:
error: unknown type name 'cpu_set_t'On musl,
cpu_set_tis only defined when _GNU_SOURCE is set.Related issues
none
Additional Notes
none
Checklist
[] I have added unit tests to the code I am submitting
[] My unit tests cover both failure and success scenarios
[] If applicable, I have discussed my architecture