Fix third-party vulnerability caused by atty v0.2.14 #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github detects third-party vulnerabilities seems to originate from the old version of clap.
vmingchen
changed the title
glommer
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github detects third-party vulnerabilities seems to originate from the storage example.
What does this PR do?
atty has security vulnerability and is used by pretty-bytes and an old clap version.
Fix the vulnerability by updating dependency:
So that we no longer depend on atty.
Motivation
Fix the vulnerability to make CI happy.
Additional Notes
Example output after the change:
See detailed info about the vulnerability here:
https://github.com/DataDog/glommio/actions/runs/8078793715/job/22071839053