Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional allowlist rules for locked-down kubernetes environments #27604

Merged
merged 3 commits into from
Feb 14, 2025
Merged

Additional allowlist rules for locked-down kubernetes environments #27604

merged 3 commits into from
Feb 14, 2025
+12 −0

Conversation

MassimoSporchia
Copy link
Contributor

What does this PR do? What is the motivation?

Adds additional allowlist rules for locked-down kubernetes environments (source: link)

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@MassimoSporchia MassimoSporchia requested a review from a team as a code owner February 13, 2025 09:32
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

rtrieu
rtrieu requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@rtrieu rtrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, but otherwise looks good!

@hestonhoffman hestonhoffman requested a review from rtrieu February 14, 2025 16:17
@hestonhoffman
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 14, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-14 16:17:33 UTC ℹ️ Start processing command /merge

2025-02-14 16:17:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-02-14 16:30:10 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-02-14 16:36:55 UTC ℹ️ MergeQueue: This merge request was merged

@rtrieu
Copy link
Contributor

rtrieu commented Feb 14, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 14, 2025 •
edited
Loading

View all feedbacks in Devflow UI.
2025-02-14 16:29:41 UTC ℹ️ Start processing command /merge

2025-02-14 16:29:43 UTC ❌ MergeQueue

PR already in the queue with status waiting

@dd-mergequeue dd-mergequeue bot merged commit 9d3a124 into master Feb 14, 2025
21 of 25 checks passed
@dd-mergequeue dd-mergequeue bot deleted the massimo.sporchia/add-network-allowlist-for-k8s branch February 14, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hestonhoffman hestonhoffman hestonhoffman approved these changes

@rtrieu rtrieu rtrieu approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MassimoSporchia @hestonhoffman @rtrieu