Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faulty_cloud_saas_api_detection.md #27580

Closed
wants to merge 4 commits into from
Closed

Conversation

HugoPct
Copy link
Contributor

@HugoPct HugoPct commented Feb 12, 2025

update supported AWS services list

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

update supported AWS services list
@HugoPct HugoPct requested a review from a team as a code owner February 12, 2025 15:40
@joepeeples joepeeples self-assigned this Feb 12, 2025
@HugoPct
Copy link
Contributor Author

HugoPct commented Feb 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 08:53:49 UTC ℹ️ Start processing command /merge


2025-02-13 08:53:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-13 12:54:07 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@HugoPct
Copy link
Contributor Author

HugoPct commented Feb 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 13, 2025

View all feedbacks in Devflow UI.
2025-02-13 10:59:17 UTC ℹ️ Start processing command /merge


2025-02-13 10:59:19 UTC ❌ MergeQueue

PR already in the queue with status waiting

@joepeeples
Copy link
Contributor

👋 Hi @HugoPct, this PR is stuck in CI due to the branch name, which needs to follow a specific format (<Slackusername>/<description>, such as joepeeples/update-list). This is a requirement for CI to create preview builds and for validation in the merge queue.

It'd probably be simplest to open a new PR using a new branch name with this format, and then you can ping the #documentation channel for a quick approval and merge. Sorry I missed this in my previous review! I'll also talk with the Docs team about making this requirement clearer.

@HugoPct HugoPct closed this Feb 13, 2025
@HugoPct HugoPct deleted the HugoPct-patch-1 branch February 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants