Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCC-498] Add documentation for account filtering #27517

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jhassan124
Copy link
Contributor

What does this PR do? What is the motivation?

Adds documentation for the new account filtering feature.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Images Images are added/removed with this PR label Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Preview links (active after the build_preview check completes)

Modified Files

@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Feb 8, 2025
Copy link
Contributor

@hinosxz hinosxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My general feedback is that the content is great but wonder if we should keep it under the AWS tab for now

@jhassan124 jhassan124 force-pushed the jahanzeb.hassan/account-filtering-docs branch from 05e66f0 to 7ac06e6 Compare February 13, 2025 20:17
@github-actions github-actions bot removed the Architecture Everything related to the Doc backend label Feb 13, 2025
@jhassan124 jhassan124 marked this pull request as ready for review February 13, 2025 20:33
@jhassan124 jhassan124 requested a review from a team as a code owner February 13, 2025 20:33
@urseberry urseberry self-assigned this Feb 13, 2025
@rtrieu rtrieu requested a review from urseberry February 13, 2025 21:09
content/en/cloud_cost_management/aws.md Outdated Show resolved Hide resolved
content/en/cloud_cost_management/aws.md Outdated Show resolved Hide resolved
content/en/cloud_cost_management/aws.md Outdated Show resolved Hide resolved
content/en/cloud_cost_management/aws.md Outdated Show resolved Hide resolved
content/en/cloud_cost_management/aws.md Outdated Show resolved Hide resolved
content/en/cloud_cost_management/aws.md Outdated Show resolved Hide resolved
content/en/cloud_cost_management/aws.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are AWS account IDs okay to post publicly, or are they personally identifiable information (PII)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the data (AWS account ids, tags, etc.) in those screenshots is fake, so it should be fine.

@jhassan124 jhassan124 requested a review from urseberry February 14, 2025 16:16
Copy link
Contributor

@urseberry urseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! See the automatically posted comment for instructions on merging your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants