-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCC-498] Add documentation for account filtering #27517
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My general feedback is that the content is great but wonder if we should keep it under the AWS tab for now
05e66f0
to
7ac06e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are AWS account IDs okay to post publicly, or are they personally identifiable information (PII)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the data (AWS account ids, tags, etc.) in those screenshots is fake, so it should be fine.
Co-authored-by: Ursula Chen <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
Co-authored-by: Ursula Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! See the automatically posted comment for instructions on merging your PR.
What does this PR do? What is the motivation?
Adds documentation for the new account filtering feature.
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/description
naming convention) and then add the following PR comment:Additional notes