Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dynamic Instrumentation tab to Source Code Integration guide > Usage section #27216

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Add Dynamic Instrumentation tab to Source Code Integration guide > Usage section #27216

merged 12 commits into from
Jan 30, 2025
+24 −0

Conversation

sstonehill12
Copy link
Contributor

@sstonehill12 sstonehill12 commented Jan 21, 2025 •
edited
Loading

What does this PR do? What is the motivation?

Added Dynamic Instrumentation tab to Source Code Integration guide > Usage section.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@sstonehill12
Add Create New Instrumentation sample image
f2ecb01 
Add reference image for Create New Instrumentation action in Source Code Integration guide > Usage > new Dynamic Instrumentation section.
@sstonehill12
Add Dynamic Instrumentation to SCI Guide > Usage
be7e4f2 
Add Dynamic Instrumentation tab to Source Code Integration guide > Usage section.
@sstonehill12 sstonehill12 added WORK IN PROGRESS No review needed, it's a wip ;) Do Not Merge Just do not merge this PR :) labels Jan 21, 2025
@github-actions github-actions bot added Images Images are added/removed with this PR Guide Content impacting a guide labels Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

OmerRaviv
OmerRaviv approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@OmerRaviv OmerRaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot removed the Images Images are added/removed with this PR label Jan 22, 2025
@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 22, 2025
@sstonehill12 sstonehill12 removed WORK IN PROGRESS No review needed, it's a wip ;) Do Not Merge Just do not merge this PR :) labels Jan 23, 2025
@sstonehill12 sstonehill12 marked this pull request as ready for review January 23, 2025 19:00
@sstonehill12 sstonehill12 requested a review from a team as a code owner January 23, 2025 19:00
jhgilbert
jhgilbert reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jhgilbert jhgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, @sstonehill12! I added a few minor suggestions, I can take a look at the preview and approve once you've reviewed those.

content/en/integrations/guide/source-code-integration.md Outdated Show resolved Hide resolved
content/en/integrations/guide/source-code-integration.md Outdated Show resolved Hide resolved
content/en/integrations/guide/source-code-integration.md Outdated Show resolved Hide resolved
@jhgilbert jhgilbert self-assigned this Jan 27, 2025
@jhgilbert jhgilbert removed their assignment Jan 27, 2025
@sstonehill12
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 30, 2025 •
edited
Loading

Devflow running: /merge

View all feedbacks in Devflow UI.

2025-01-30 19:59:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-01-30 22:12:07 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.

2025-01-30 22:18:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5c11a52 into master Jan 30, 2025
16 of 17 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sarah.stonehill/sci-guide-usage-di-addition branch January 30, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson left review comments

@markazerdd markazerdd markazerdd approved these changes

@shatzi shatzi shatzi approved these changes

@jhgilbert jhgilbert jhgilbert approved these changes

@OmerRaviv OmerRaviv OmerRaviv approved these changes

Assignees
No one assigned
Labels
Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sstonehill12 @watson @OmerRaviv @jhgilbert @shatzi @markazerdd