Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS-9921] Add attacker clustering & attacker fingerprint public doc #27194

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

emmlejeail
Copy link

@emmlejeail emmlejeail commented Jan 20, 2025

What does this PR do? What is the motivation?

  • This PR adds documentation for two recently released features of ASM: attacker fingerprint & attacker clustering
  • The pages are added under the Threats section of ASM docs
  • Terms are updated to reference those pages too
  • Screenshots to illustrate attacker fingerprint & attacker clustering

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Images Images are added/removed with this PR label Jan 20, 2025
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Jan 20, 2025
@emmlejeail emmlejeail marked this pull request as ready for review January 22, 2025 09:49
@emmlejeail emmlejeail requested a review from a team as a code owner January 22, 2025 09:49
@emmlejeail emmlejeail requested a review from jkirsteins January 22, 2025 09:49
Copy link
Contributor

@jkirsteins jkirsteins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the screenshots provided:

  • It's not obvious what the screenshots are illustrating, without context imho. I'd suggest adding some guidance on where to look. E.g. we show a screenshot for detection rule editor -> should be a red box showing that focus should be on the tag part.
    • Or if we show the signal sidepanel, a red box should show that the interesting bit is the attacker section at the bottom.
  • All of the IPs should be blurred out. IIRC that's the policy for screeenshots showing any kind of IP/user/email information, even if randomly generated.


## Overview

Datadog Attacker fingerprints are a threat hunting tool. They are automatically computed and added to your traces on attack or login attempts when Application Security Management (ASM) is enabled on your service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are a threat hunting tool.

Are they useful for anything outside of attacker clustering?

My intuitive understanding is no - the data is fragmented across many attributes, and those are not very clear how to use manually.

Unless we can share some use cases that don't involve relying on Attacker Clustering, I'd suggest framing this as a feature mainly intended to power attacker clustering.

I'd go even further - if they don't have standalone use cases we can demonstrate, I think this content should be on the Attacker Clustering doc page and not separate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to use it for blocking or more advanced threat hunting (probably requires good example from @Taiki-San) so I would keep it on it's own page. However it's true that at the moment it's only used for clustering so I'll focus the explanation on that

@buraizu buraizu changed the title Add attacker clustering & attacker fingerprint public doc [DOCS-9921] Add attacker clustering & attacker fingerprint public doc Jan 22, 2025
@buraizu buraizu added the editorial review Waiting on a more in-depth review label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants