Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify that APM metrics include tags from DD_TAGS #27099

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

darccio
Copy link
Member

@darccio darccio commented Jan 14, 2025

What does this PR do? What is the motivation?

Adds that metrics are submitted to the agent from the Go tracer including tags from DD_TAGS environment variables.

Source: DataDog/dd-trace-go#3067

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

@darccio darccio requested a review from a team as a code owner January 14, 2025 15:17
@darccio darccio requested review from mtoffl01 and a team January 14, 2025 15:17
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small edit!

content/en/tracing/trace_collection/library_config/go.md Outdated Show resolved Hide resolved
Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @darccio! Feel free /merge when good to go.

@darccio
Copy link
Member Author

darccio commented Jan 15, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 15, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-15 15:12:11 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-15 15:53:31 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in master is 7m.


2025-01-15 16:01:38 UTC ℹ️ MergeQueue: This merge request was merged

@darccio
Copy link
Member Author

darccio commented Jan 15, 2025

@maycmlee The PR is missing your approval 😃

@dd-mergequeue dd-mergequeue bot merged commit bf44a7b into master Jan 15, 2025
22 of 23 checks passed
@dd-mergequeue dd-mergequeue bot deleted the dario.castane/statsd-ddtags branch January 15, 2025 16:01
@darccio
Copy link
Member Author

darccio commented Jan 15, 2025

Thanks @maycmlee!

domalessi pushed a commit that referenced this pull request Jan 20, 2025
* fix: clarify that metrics include tags from DD_TAGS

* Update content/en/tracing/trace_collection/library_config/go.md

Co-authored-by: May Lee <[email protected]>

---------

Co-authored-by: May Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants