Skip to content

Commit

Permalink
clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
juan-fernandez committed Jan 8, 2025
1 parent 25a1877 commit f55d1e4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,16 @@ class TestVisDynamicInstrumentation {
}

removeProbe (probeId) {
// breakpointRemoveChannel
return new Promise(resolve => {
this.breakpointRemoveChannel.port2.postMessage(probeId)

probeIdToResolveBreakpointRemove.set(probeId, resolve)
})
}

// Return 3 elements:
// 1. Snapshot ID
// Return 2 elements:
// 1. Probe ID
// 2. Promise that's resolved when the breakpoint is set
// 3. Promise that's resolved when the breakpoint is hit
addLineProbe ({ file, line }, onHitBreakpoint) {
const probeId = randomUUID()

Expand Down
1 change: 0 additions & 1 deletion packages/dd-trace/src/plugins/ci_plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ module.exports = class CiPlugin extends Plugin {
return this.di.removeProbe(probeId)
}

// TODO: If the test finishes and the probe is not hit, we should remove the breakpoint
addDiProbe (err, onHitBreakpoint) {
const [file, line, stackIndex] = getFileAndLineNumberFromError(err, this.repositoryRoot)

Expand Down

0 comments on commit f55d1e4

Please sign in to comment.