Skip to content

Commit

Permalink
remove http.route from inferred proxy spans (#5132)
Browse files Browse the repository at this point in the history
remove inferred http route
  • Loading branch information
zarirhamza authored Jan 22, 2025
1 parent 37546ab commit c28765a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions packages/dd-trace/src/plugins/util/inferred_proxy.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ const log = require('../../log')
const tags = require('../../../../../ext/tags')

const RESOURCE_NAME = tags.RESOURCE_NAME
const HTTP_ROUTE = tags.HTTP_ROUTE
const SPAN_KIND = tags.SPAN_KIND
const SPAN_TYPE = tags.SPAN_TYPE
const HTTP_URL = tags.HTTP_URL
Expand Down Expand Up @@ -54,7 +53,6 @@ function createInferredProxySpan (headers, childOf, tracer, context) {
[SPAN_TYPE]: 'web',
[HTTP_METHOD]: proxyContext.method,
[HTTP_URL]: proxyContext.domainName + proxyContext.path,
[HTTP_ROUTE]: proxyContext.path,
stage: proxyContext.stage
}
}
Expand Down
2 changes: 0 additions & 2 deletions packages/dd-trace/test/plugins/util/inferred_proxy.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ describe('Inferred Proxy Spans', function () {
expect(spans[0].meta).to.have.property('http.url', 'example.com/test')
expect(spans[0].meta).to.have.property('http.method', 'GET')
expect(spans[0].meta).to.have.property('http.status_code', '200')
expect(spans[0].meta).to.have.property('http.route', '/test')
expect(spans[0].meta).to.have.property('span.kind', 'internal')
expect(spans[0].meta).to.have.property('component', 'aws-apigateway')
expect(spans[0].meta).to.have.property('_dd.inferred_span', '1')
Expand Down Expand Up @@ -130,7 +129,6 @@ describe('Inferred Proxy Spans', function () {
expect(spans[0].meta).to.have.property('http.url', 'example.com/test')
expect(spans[0].meta).to.have.property('http.method', 'GET')
expect(spans[0].meta).to.have.property('http.status_code', '500')
expect(spans[0].meta).to.have.property('http.route', '/test')
expect(spans[0].meta).to.have.property('span.kind', 'internal')
expect(spans[0].meta).to.have.property('component', 'aws-apigateway')
expect(spans[0].error).to.be.equal(1)
Expand Down

0 comments on commit c28765a

Please sign in to comment.