Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to mandatory issue templates #8106

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Switch to mandatory issue templates #8106

wants to merge 5 commits into from
+125 −8

Conversation

tlhunter
Copy link
Member

@tlhunter tlhunter commented Dec 17, 2024 •
edited by jira bot
Loading

What Does This Do

  • standardizes the issue creation screen
  • standardizes the security policy document
  • makes issue templates mandatory
  • creates a bug report and feature request issue template

Motivation

  • standardizes the create issue screen across tracers

Additional Notes

Contributor Checklist

Jira ticket: AIDM-429

@tlhunter tlhunter added type: documentation tag: no release notes Changes to exclude from release notes labels Dec 17, 2024
@tlhunter tlhunter requested a review from a team as a code owner December 17, 2024 22:33
@tlhunter tlhunter requested a review from amarziali December 17, 2024 22:33
@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tlhunter/create-issue-standard
git_commit_date 1736160002 1736207830
git_commit_sha 0c2f7ff 9d5f457
release_version 1.45.0-SNAPSHOT~0c2f7ff792 1.45.0-SNAPSHOT~9d5f4571a6
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736210278 1736210278
ci_job_id 756244772 756244772
ci_pipeline_id 52285576 52285576
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.058 s) : 0, 1057798
Total [baseline] (10.402 s) : 0, 10401840
Agent [candidate] (1.058 s) : 0, 1058496
Total [candidate] (10.481 s) : 0, 10481446
section appsec
Agent [baseline] (1.192 s) : 0, 1192336
Total [baseline] (10.746 s) : 0, 10746114
Agent [candidate] (1.191 s) : 0, 1191041
Total [candidate] (10.675 s) : 0, 10674777
section iast
Agent [baseline] (1.187 s) : 0, 1186956
Total [baseline] (10.97 s) : 0, 10969917
Agent [candidate] (1.198 s) : 0, 1198240
Total [candidate] (11.062 s) : 0, 11062188
section profiling
Agent [baseline] (1.278 s) : 0, 1277541
Total [baseline] (10.829 s) : 0, 10829275
Agent [candidate] (1.282 s) : 0, 1281725
Total [candidate] (10.853 s) : 0, 10852552
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.192 s 134.539 ms (12.7%)
Agent iast 1.187 s 129.159 ms (12.2%)
Agent profiling 1.278 s 219.743 ms (20.8%)
Total tracing 10.402 s -
Total appsec 10.746 s 344.275 ms (3.3%)
Total iast 10.97 s 568.077 ms (5.5%)
Total profiling 10.829 s 427.435 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent appsec 1.191 s 132.545 ms (12.5%)
Agent iast 1.198 s 139.745 ms (13.2%)
Agent profiling 1.282 s 223.229 ms (21.1%)
Total tracing 10.481 s -
Total appsec 10.675 s 193.331 ms (1.8%)
Total iast 11.062 s 580.742 ms (5.5%)
Total profiling 10.853 s 371.106 ms (3.5%) 
gantt
    title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.947 ms) : 0, 715947
BytebuddyAgent [candidate] (716.618 ms) : 0, 716618
GlobalTracer [baseline] (256.471 ms) : 0, 256471
GlobalTracer [candidate] (256.188 ms) : 0, 256188
AppSec [baseline] (56.982 ms) : 0, 56982
AppSec [candidate] (55.58 ms) : 0, 55580
Remote Config [baseline] (726.179 µs) : 0, 726
Remote Config [candidate] (754.99 µs) : 0, 755
Telemetry [baseline] (12.568 ms) : 0, 12568
Telemetry [candidate] (14.158 ms) : 0, 14158
section appsec
BytebuddyAgent [baseline] (734.54 ms) : 0, 734540
BytebuddyAgent [candidate] (732.877 ms) : 0, 732877
GlobalTracer [baseline] (253.728 ms) : 0, 253728
GlobalTracer [candidate] (254.116 ms) : 0, 254116
AppSec [baseline] (170.445 ms) : 0, 170445
AppSec [candidate] (170.046 ms) : 0, 170046
Remote Config [baseline] (653.307 µs) : 0, 653
Remote Config [candidate] (658.841 µs) : 0, 659
Telemetry [baseline] (7.953 ms) : 0, 7953
Telemetry [candidate] (7.909 ms) : 0, 7909
IAST [baseline] (19.972 ms) : 0, 19972
IAST [candidate] (20.719 ms) : 0, 20719
section iast
BytebuddyAgent [baseline] (835.026 ms) : 0, 835026
BytebuddyAgent [candidate] (843.995 ms) : 0, 843995
GlobalTracer [baseline] (247.888 ms) : 0, 247888
GlobalTracer [candidate] (249.845 ms) : 0, 249845
AppSec [baseline] (58.499 ms) : 0, 58499
AppSec [candidate] (58.172 ms) : 0, 58172
Remote Config [baseline] (649.845 µs) : 0, 650
Remote Config [candidate] (666.042 µs) : 0, 666
Telemetry [baseline] (8.598 ms) : 0, 8598
Telemetry [candidate] (8.626 ms) : 0, 8626
IAST [baseline] (21.21 ms) : 0, 21210
IAST [candidate] (21.572 ms) : 0, 21572
section profiling
ProfilingAgent [baseline] (95.859 ms) : 0, 95859
ProfilingAgent [candidate] (95.459 ms) : 0, 95459
BytebuddyAgent [baseline] (703.992 ms) : 0, 703992
BytebuddyAgent [candidate] (707.798 ms) : 0, 707798
GlobalTracer [baseline] (372.635 ms) : 0, 372635
GlobalTracer [candidate] (373.781 ms) : 0, 373781
AppSec [baseline] (54.804 ms) : 0, 54804
AppSec [candidate] (54.048 ms) : 0, 54048
Remote Config [baseline] (655.187 µs) : 0, 655
Remote Config [candidate] (662.863 µs) : 0, 663
Telemetry [baseline] (7.834 ms) : 0, 7834
Telemetry [candidate] (7.894 ms) : 0, 7894
Profiling [baseline] (95.883 ms) : 0, 95883
Profiling [candidate] (95.483 ms) : 0, 95483
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054189
Total [baseline] (8.649 s) : 0, 8649328
Agent [candidate] (1.055 s) : 0, 1055360
Total [candidate] (8.645 s) : 0, 8645026
section iast
Agent [baseline] (1.186 s) : 0, 1186362
Total [baseline] (9.219 s) : 0, 9218865
Agent [candidate] (1.18 s) : 0, 1179746
Total [candidate] (9.216 s) : 0, 9215910
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.181 s) : 0, 1180519
Total [baseline] (9.149 s) : 0, 9148737
Agent [candidate] (1.197 s) : 0, 1196931
Total [candidate] (9.198 s) : 0, 9197535
section iast_TELEMETRY_OFF
Agent [baseline] (1.176 s) : 0, 1176339
Total [baseline] (9.174 s) : 0, 9174020
Agent [candidate] (1.177 s) : 0, 1177049
Total [candidate] (9.21 s) : 0, 9209638
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.054 s -
Agent iast 1.186 s 132.174 ms (12.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.181 s 126.33 ms (12.0%)
Agent iast_TELEMETRY_OFF 1.176 s 122.15 ms (11.6%)
Total tracing 8.649 s -
Total iast 9.219 s 569.538 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.149 s 499.409 ms (5.8%)
Total iast_TELEMETRY_OFF 9.174 s 524.692 ms (6.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent iast 1.18 s 124.385 ms (11.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.197 s 141.571 ms (13.4%)
Agent iast_TELEMETRY_OFF 1.177 s 121.689 ms (11.5%)
Total tracing 8.645 s -
Total iast 9.216 s 570.884 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.198 s 552.509 ms (6.4%)
Total iast_TELEMETRY_OFF 9.21 s 564.612 ms (6.5%) 
gantt
    title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.555 ms) : 0, 713555
BytebuddyAgent [candidate] (713.96 ms) : 0, 713960
GlobalTracer [baseline] (255.533 ms) : 0, 255533
GlobalTracer [candidate] (256.504 ms) : 0, 256504
AppSec [baseline] (56.534 ms) : 0, 56534
AppSec [candidate] (56.029 ms) : 0, 56029
Remote Config [baseline] (737.001 µs) : 0, 737
Remote Config [candidate] (710.817 µs) : 0, 711
Telemetry [baseline] (12.798 ms) : 0, 12798
Telemetry [candidate] (13.229 ms) : 0, 13229
section iast
BytebuddyAgent [baseline] (835.406 ms) : 0, 835406
BytebuddyAgent [candidate] (830.568 ms) : 0, 830568
GlobalTracer [baseline] (247.456 ms) : 0, 247456
GlobalTracer [candidate] (246.49 ms) : 0, 246490
AppSec [baseline] (58.191 ms) : 0, 58191
AppSec [candidate] (57.982 ms) : 0, 57982
Remote Config [baseline] (665.523 µs) : 0, 666
Remote Config [candidate] (633.545 µs) : 0, 634
Telemetry [baseline] (8.547 ms) : 0, 8547
Telemetry [candidate] (8.384 ms) : 0, 8384
IAST [baseline] (21.056 ms) : 0, 21056
IAST [candidate] (20.706 ms) : 0, 20706
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.485 ms) : 0, 830485
BytebuddyAgent [candidate] (842.155 ms) : 0, 842155
GlobalTracer [baseline] (246.507 ms) : 0, 246507
GlobalTracer [candidate] (249.586 ms) : 0, 249586
AppSec [baseline] (58.097 ms) : 0, 58097
AppSec [candidate] (58.893 ms) : 0, 58893
Remote Config [baseline] (652.535 µs) : 0, 653
Remote Config [candidate] (672.031 µs) : 0, 672
Telemetry [baseline] (8.531 ms) : 0, 8531
Telemetry [candidate] (8.713 ms) : 0, 8713
IAST [baseline] (21.227 ms) : 0, 21227
IAST [candidate] (21.56 ms) : 0, 21560
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.779 ms) : 0, 827779
BytebuddyAgent [candidate] (827.925 ms) : 0, 827925
GlobalTracer [baseline] (246.573 ms) : 0, 246573
GlobalTracer [candidate] (246.495 ms) : 0, 246495
AppSec [baseline] (57.49 ms) : 0, 57490
AppSec [candidate] (57.781 ms) : 0, 57781
Remote Config [baseline] (630.886 µs) : 0, 631
Remote Config [candidate] (641.617 µs) : 0, 642
Telemetry [baseline] (8.286 ms) : 0, 8286
Telemetry [candidate] (8.4 ms) : 0, 8400
IAST [baseline] (20.606 ms) : 0, 20606
IAST [candidate] (20.807 ms) : 0, 20807
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-07T00:08:12 2025-01-07T00:15:12
git_branch master tlhunter/create-issue-standard
git_commit_date 1736160002 1736207830
git_commit_sha 0c2f7ff 9d5f457
release_version 1.45.0-SNAPSHOT~0c2f7ff792 1.45.0-SNAPSHOT~9d5f4571a6
start_time 2025-01-07T00:07:58 2025-01-07T00:14:58
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1736209266 1736209266
ci_job_id 756244773 756244773
ci_pipeline_id 52285576 52285576
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.073 µs) : 362, 404
.   : milestone, 383,
iast (498.414 µs) : 477, 520
.   : milestone, 498,
iast_FULL (652.837 µs) : 631, 675
.   : milestone, 653,
iast_GLOBAL (529.401 µs) : 507, 552
.   : milestone, 529,
iast_HARDCODED_SECRET_DISABLED (490.9 µs) : 469, 512
.   : milestone, 491,
iast_INACTIVE (458.734 µs) : 437, 481
.   : milestone, 459,
iast_TELEMETRY_OFF (483.756 µs) : 462, 505
.   : milestone, 484,
tracing (454.47 µs) : 433, 476
.   : milestone, 454,
section candidate
no_agent (378.287 µs) : 358, 399
.   : milestone, 378,
iast (496.793 µs) : 475, 518
.   : milestone, 497,
iast_FULL (659.344 µs) : 638, 681
.   : milestone, 659,
iast_GLOBAL (518.621 µs) : 497, 540
.   : milestone, 519,
iast_HARDCODED_SECRET_DISABLED (495.955 µs) : 474, 518
.   : milestone, 496,
iast_INACTIVE (451.67 µs) : 431, 472
.   : milestone, 452,
iast_TELEMETRY_OFF (480.131 µs) : 459, 502
.   : milestone, 480,
tracing (449.197 µs) : 428, 470
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 383.073 µs [362.448 µs, 403.699 µs] -
iast 498.414 µs [476.517 µs, 520.311 µs] 115.34 µs (30.1%)
iast_FULL 652.837 µs [631.049 µs, 674.625 µs] 269.764 µs (70.4%)
iast_GLOBAL 529.401 µs [507.044 µs, 551.758 µs] 146.328 µs (38.2%)
iast_HARDCODED_SECRET_DISABLED 490.9 µs [469.433 µs, 512.367 µs] 107.826 µs (28.1%)
iast_INACTIVE 458.734 µs [436.512 µs, 480.956 µs] 75.661 µs (19.8%)
iast_TELEMETRY_OFF 483.756 µs [462.025 µs, 505.487 µs] 100.682 µs (26.3%)
tracing 454.47 µs [433.256 µs, 475.683 µs] 71.396 µs (18.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 378.287 µs [357.927 µs, 398.648 µs] -
iast 496.793 µs [475.132 µs, 518.455 µs] 118.506 µs (31.3%)
iast_FULL 659.344 µs [637.705 µs, 680.983 µs] 281.056 µs (74.3%)
iast_GLOBAL 518.621 µs [496.985 µs, 540.257 µs] 140.334 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 495.955 µs [473.673 µs, 518.237 µs] 117.668 µs (31.1%)
iast_INACTIVE 451.67 µs [430.892 µs, 472.448 µs] 73.383 µs (19.4%)
iast_TELEMETRY_OFF 480.131 µs [458.637 µs, 501.626 µs] 101.844 µs (26.9%)
tracing 449.197 µs [427.92 µs, 470.473 µs] 70.909 µs (18.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.362 ms) : 1342, 1383
.   : milestone, 1362,
appsec (1.782 ms) : 1758, 1805
.   : milestone, 1782,
appsec_no_iast (1.758 ms) : 1734, 1782
.   : milestone, 1758,
iast (1.494 ms) : 1470, 1517
.   : milestone, 1494,
profiling (1.504 ms) : 1480, 1527
.   : milestone, 1504,
tracing (1.484 ms) : 1460, 1508
.   : milestone, 1484,
section candidate
no_agent (1.36 ms) : 1341, 1380
.   : milestone, 1360,
appsec (1.758 ms) : 1734, 1782
.   : milestone, 1758,
appsec_no_iast (1.758 ms) : 1734, 1783
.   : milestone, 1758,
iast (1.51 ms) : 1487, 1533
.   : milestone, 1510,
profiling (1.544 ms) : 1519, 1569
.   : milestone, 1544,
tracing (1.499 ms) : 1475, 1523
.   : milestone, 1499,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.342 ms, 1.383 ms] -
appsec 1.782 ms [1.758 ms, 1.805 ms] 419.542 µs (30.8%)
appsec_no_iast 1.758 ms [1.734 ms, 1.782 ms] 396.003 µs (29.1%)
iast 1.494 ms [1.47 ms, 1.517 ms] 131.431 µs (9.6%)
profiling 1.504 ms [1.48 ms, 1.527 ms] 141.614 µs (10.4%)
tracing 1.484 ms [1.46 ms, 1.508 ms] 122.106 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.36 ms [1.341 ms, 1.38 ms] -
appsec 1.758 ms [1.734 ms, 1.782 ms] 397.86 µs (29.3%)
appsec_no_iast 1.758 ms [1.734 ms, 1.783 ms] 397.933 µs (29.3%)
iast 1.51 ms [1.487 ms, 1.533 ms] 150.021 µs (11.0%)
profiling 1.544 ms [1.519 ms, 1.569 ms] 183.769 µs (13.5%)
tracing 1.499 ms [1.475 ms, 1.523 ms] 139.049 µs (10.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master tlhunter/create-issue-standard
git_commit_date 1736160002 1736207830
git_commit_sha 0c2f7ff 9d5f457
release_version 1.45.0-SNAPSHOT~0c2f7ff792 1.45.0-SNAPSHOT~9d5f4571a6
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1736209839 1736209839
ci_job_id 756244774 756244774
ci_pipeline_id 52285576 52285576
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.41 s) : 15410000, 15410000
.   : milestone, 15410000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.884 s) : 18884000, 18884000
.   : milestone, 18884000,
iast_GLOBAL (18.45 s) : 18450000, 18450000
.   : milestone, 18450000,
profiling (15.732 s) : 15732000, 15732000
.   : milestone, 15732000,
tracing (14.89 s) : 14890000, 14890000
.   : milestone, 14890000,
section candidate
no_agent (15.463 s) : 15463000, 15463000
.   : milestone, 15463000,
appsec (15.075 s) : 15075000, 15075000
.   : milestone, 15075000,
iast (18.917 s) : 18917000, 18917000
.   : milestone, 18917000,
iast_GLOBAL (17.805 s) : 17805000, 17805000
.   : milestone, 17805000,
profiling (15.568 s) : 15568000, 15568000
.   : milestone, 15568000,
tracing (15.01 s) : 15010000, 15010000
.   : milestone, 15010000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.41 s [15.41 s, 15.41 s] -
appsec 14.998 s [14.998 s, 14.998 s] -412.0 ms (-2.7%)
iast 18.884 s [18.884 s, 18.884 s] 3.474 s (22.5%)
iast_GLOBAL 18.45 s [18.45 s, 18.45 s] 3.04 s (19.7%)
profiling 15.732 s [15.732 s, 15.732 s] 322.0 ms (2.1%)
tracing 14.89 s [14.89 s, 14.89 s] -520.0 ms (-3.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.463 s [15.463 s, 15.463 s] -
appsec 15.075 s [15.075 s, 15.075 s] -388.0 ms (-2.5%)
iast 18.917 s [18.917 s, 18.917 s] 3.454 s (22.3%)
iast_GLOBAL 17.805 s [17.805 s, 17.805 s] 2.342 s (15.1%)
profiling 15.568 s [15.568 s, 15.568 s] 105.0 ms (0.7%)
tracing 15.01 s [15.01 s, 15.01 s] -453.0 ms (-2.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~9d5f4571a6, baseline=1.45.0-SNAPSHOT~0c2f7ff792
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
.   : milestone, 1472,
appsec (2.359 ms) : 2317, 2402
.   : milestone, 2359,
iast (2.103 ms) : 2049, 2157
.   : milestone, 2103,
iast_GLOBAL (2.137 ms) : 2083, 2191
.   : milestone, 2137,
profiling (1.97 ms) : 1926, 2013
.   : milestone, 1970,
tracing (1.937 ms) : 1896, 1978
.   : milestone, 1937,
section candidate
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (2.367 ms) : 2324, 2410
.   : milestone, 2367,
iast (2.103 ms) : 2049, 2157
.   : milestone, 2103,
iast_GLOBAL (2.15 ms) : 2095, 2204
.   : milestone, 2150,
profiling (1.956 ms) : 1913, 1999
.   : milestone, 1956,
tracing (1.945 ms) : 1903, 1987
.   : milestone, 1945,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.46 ms, 1.483 ms] -
appsec 2.359 ms [2.317 ms, 2.402 ms] 887.605 µs (60.3%)
iast 2.103 ms [2.049 ms, 2.157 ms] 631.283 µs (42.9%)
iast_GLOBAL 2.137 ms [2.083 ms, 2.191 ms] 665.47 µs (45.2%)
profiling 1.97 ms [1.926 ms, 2.013 ms] 497.887 µs (33.8%)
tracing 1.937 ms [1.896 ms, 1.978 ms] 465.328 µs (31.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 2.367 ms [2.324 ms, 2.41 ms] 894.67 µs (60.8%)
iast 2.103 ms [2.049 ms, 2.157 ms] 631.137 µs (42.9%)
iast_GLOBAL 2.15 ms [2.095 ms, 2.204 ms] 677.475 µs (46.0%)
profiling 1.956 ms [1.913 ms, 1.999 ms] 483.949 µs (32.9%)
tracing 1.945 ms [1.903 ms, 1.987 ms] 472.883 µs (32.1%)

@PerfectSlayer PerfectSlayer self-requested a review December 18, 2024 07:31
PerfectSlayer
PerfectSlayer reviewed Dec 18, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yaml
@@ -0,0 +1,34 @@
name: "Bug Report (Low Priority)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the low / high priority wording approved as a public facing support level?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We came up with it during the ideation phase a quarter ago, I believe the OSS team looked it over, and the Node.js tracer has been using it for months.

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml
@@ -1,8 +1,8 @@
blank_issues_enabled: true
blank_issues_enabled: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about all the other types of issue? Performance discussions, questions, help requests?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add additional templates for them. Other tracers either don't support freeform discussion or use the discussions tab. Are those three topics the finite list that you would like supported? Also, what default tags would you want applied?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say it’s mainly performance related, or a question / help request.
I don’t know how the other tracers are handling it using GitHub?

.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
SECURITY.md Outdated Show resolved Hide resolved
@PerfectSlayer PerfectSlayer changed the title repo: mandatory issue templates (AIDM-429) Switch to mandatory issue templates Dec 18, 2024
@tlhunter tlhunter force-pushed the tlhunter/create-issue-standard branch from 4a073d2 to e20b4cf Compare December 18, 2024 23:32
ygree
ygree approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlhunter tlhunter enabled auto-merge (squash) January 6, 2025 23:57
@tlhunter tlhunter force-pushed the tlhunter/create-issue-standard branch from 6014e5c to 9d5f457 Compare January 6, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali left review comments

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@ygree ygree ygree approved these changes

Assignees
No one assigned
Labels
tag: no release notes Changes to exclude from release notes type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlhunter @PerfectSlayer @ygree @amarziali