Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] contrib/IBM/sarama: support for consumer groups #3072

Open
wants to merge 5 commits into
base: v2-dev
Choose a base branch
from

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Jan 9, 2025

What does this PR do?

Port of #3041

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@rarguelloF rarguelloF requested review from a team as code owners January 9, 2025 13:44
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 9, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jan 9, 2025

Datadog Report

Branch report: rarguelloF/AIDM-461/v2-support-sarama-consumer-group
Commit report: 944a363
Test service: dd-trace-go

✅ 0 Failed, 4076 Passed, 64 Skipped, 2m 49.74s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2025

Benchmarks

Benchmark execution time: 2025-01-09 15:36:10

Comparing candidate commit 20cf6a3 in PR branch rarguelloF/AIDM-461/v2-support-sarama-consumer-group with baseline commit 89bfc59 in branch v2-dev.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 1 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants